As the description says, it grants a +5 bonus for all positive morale checks, i.e. those determining if the morale state should be upped. This means that optimistic characters have a higher chance to gain morale (e.g. changing from stable to confident) on events such as slaying an enemy or seeing an enemy slain by an ally. It is working as intended.
